Enable s8 in QuantizedMaxPool2d kernel #1304
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xytintel
approved these changes
Jan 20, 2025
fengyuan14
reviewed
Jan 20, 2025
| @@ -32,7 +33,7 @@ class QMaxPool_arr_args final { | |||
| bool ceil_mode) { | |||
| // Now we only support Byte, qint is not supported. | |||
| TORCH_CHECK( | |||
| qx.scalar_type() == c10::ScalarType::Byte, | |||
| qx.scalar_type() == c10::ScalarType::Byte || qx.scalar_type() == c10::ScalarType::Char, | |||
| "QuantizedMaxPool2d only supports Byte for xpu now"); | |||
There was a problem hiding this comment.
Make the error log correct.
There was a problem hiding this comment.
Have fixed, thanks for your kind reminding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kChar to the allow data type in QuantizedMaxPool2d kernel, it is required at PT2E side.